Import cleanup deletes DNS-exception rules that are never added #158

New issue

Closed

opened 2026-08-24 17:30:47 -04:00 by mysticalsoap · 0 comments

mysticalsoap commented

2026-08-24 17:30:47 -04:00

Owner

Every successful import's downloaded() calls dns_request_exception("-D", ...), but the matching "-I" call exists nowhere in the codebase — upstream added the exception so hostnames in downloaded configs could resolve while the firewall is up, and the insert side was lost in the fork. The surviving delete fails 8 times per import (udp/tcp x INPUT/OUTPUT x v4/v6), each logged as a WARNING.

Purely cosmetic with the firewall off, but for firewall-on users it means the thing the exception existed for is silently missing during imports. Decide whether to restore the "-I" around the import or drop the dangling "-D" (and its alt_dns plumbing) entirely.

Surfaced while live-verifying PR #157 — the failed-delete batch appears after every import back through the log history, so it predates that change.

🤖 Generated with Claude Code

Every successful import's `downloaded()` calls `dns_request_exception("-D", ...)`, but the matching `"-I"` call exists nowhere in the codebase — upstream added the exception so hostnames in downloaded configs could resolve while the firewall is up, and the insert side was lost in the fork. The surviving delete fails 8 times per import (udp/tcp x INPUT/OUTPUT x v4/v6), each logged as a WARNING. Purely cosmetic with the firewall off, but for firewall-on users it means the thing the exception existed for is silently missing during imports. Decide whether to restore the `"-I"` around the import or drop the dangling `"-D"` (and its `alt_dns` plumbing) entirely. Surfaced while live-verifying PR #157 — the failed-delete batch appears after every import back through the log history, so it predates that change. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

mysticalsoap referenced this issue

2026-08-24 17:30:58 -04:00

Get provider auto-update working, cleanly for ProtonVPN #157

mysticalsoap referenced this issue from a commit

2026-08-24 17:42:41 -04:00

fix: open the import's DNS exception again, and close every rule on failure

mysticalsoap referenced this issue from a pull request that will close it,

2026-08-24 17:42:54 -04:00

Restore the import DNS exception and close temporary rules on every exit #159

mysticalsoap closed this issue

2026-08-24 18:34:14 -04:00

mysticalsoap referenced this issue