Unhandled exceptions in TunnelThread abort the root service #17

New issue

Closed

opened 2026-08-17 16:57:01 -04:00 by mysticalsoap · 0 comments

mysticalsoap commented

2026-08-17 16:57:01 -04:00

Owner

TunnelThread.run (aqomui/tunnel.py:34-47) catches only KeyError, and
that except is a fallback for a server dict without a tunnel key -- not an
error guard. Anything raised by openvpn() or wireguard() reaches the top of
the QThread.

PyQt5 aborts the process when an exception escapes a QThread, and this thread
runs inside the root D-Bus service, so one unexpected error kills the service
and every active tunnel with it.

AddServers.run was guarded for exactly this in 14dd13a, but the fix was applied
to the importer only -- the more central thread was left unguarded. Bug #2 was
reported as solved and is still live in the place that matters more.

Treat it as one pattern rather than two instances: a single decorator or base
run() wrapper applied to every QThread the service owns, turning an escaped
exception into a failure signal.

Related: the broad swallows that hide failure rather than report it --
firewall.py:165 (except BaseException) and tunnel.py:489 (bare except:).

`TunnelThread.run` (`aqomui/tunnel.py:34-47`) catches only `KeyError`, and that `except` is a *fallback* for a server dict without a `tunnel` key -- not an error guard. Anything raised by `openvpn()` or `wireguard()` reaches the top of the QThread. PyQt5 aborts the process when an exception escapes a QThread, and this thread runs inside the **root D-Bus service**, so one unexpected error kills the service and every active tunnel with it. `AddServers.run` was guarded for exactly this in 14dd13a, but the fix was applied to the importer only -- the more central thread was left unguarded. Bug #2 was reported as solved and is still live in the place that matters more. Treat it as one pattern rather than two instances: a single decorator or base `run()` wrapper applied to every QThread the service owns, turning an escaped exception into a failure signal. Related: the broad swallows that hide failure rather than report it -- `firewall.py:165` (`except BaseException`) and `tunnel.py:489` (bare `except:`).

mysticalsoap added the

bug

security

labels

2026-08-17 16:57:01 -04:00

mysticalsoap referenced this issue from a pull request that will close it,

2026-08-17 18:38:53 -04:00

fix: keep unhandled service-thread errors from killing the root service #37

mysticalsoap closed this issue

2026-08-17 21:09:13 -04:00