mysticalsoap/aqomui
Watch
1
0
Fork
You've already forked aqomui
 0
Code Issues 38 Pull requests Releases 3 Packages Wiki Activity Actions

change: drop the legacy scripts-key scrub from load_config #199

Merged
mysticalsoap merged 1 commit from drop-config-scrub into trunk 2026-08-28 18:39:31 -04:00
Conversation 0 Commits 1 Files changed 2 -22
mysticalsoap commented 2026-08-28 18:36:50 -04:00
Owner
Copy link

Problem

The custom-scripts removal (#198) included a load_config scrub deleting stale {provider}_scripts keys from pre-removal configs. Review feedback: that trades a permanent resident code path for a one-time cosmetic cleanup — with no users, stale keys in an existing config are dead data that costs nothing, while migration code has to be carried forever.

Fix

Removes the scrub and its regression test. load_config goes back to exactly its pre-#198 shape. Stale keys in existing configs simply persist as unread data.

Verification

Full test_config suite passes; the scrub test is removed with the scrub.

🤖 Generated with Claude Code

## Problem The custom-scripts removal (#198) included a `load_config` scrub deleting stale `{provider}_scripts` keys from pre-removal configs. Review feedback: that trades a permanent resident code path for a one-time cosmetic cleanup — with no users, stale keys in an existing config are dead data that costs nothing, while migration code has to be carried forever. ## Fix Removes the scrub and its regression test. `load_config` goes back to exactly its pre-#198 shape. Stale keys in existing configs simply persist as unread data. ## Verification Full test_config suite passes; the scrub test is removed with the scrub. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
change: drop the legacy scripts-key scrub from load_config
All checks were successful
ci / test (pull_request) Successful in 23s
Details
ci / test (push) Successful in 25s
Details
3a9d4d54f6
 
The custom-scripts removal (#82) left a scrub deleting stale
{provider}_scripts keys from loaded configs. That trades a permanent
resident code path for a one-time cosmetic cleanup: with no users,
stale keys in an existing config are dead data that costs nothing,
while migration code has to be carried -- and understood -- forever.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mysticalsoap deleted branch drop-config-scrub 2026-08-28 18:39:31 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
architecture
Structural change, not a local fix

  
bug
Defect in existing behaviour

  
cleanup
Tidying with no behaviour change

  
docs
Documentation and repo standards

  
packaging
distro packages and their build tooling

  
security
Vulnerability or hardening

  
testing
Test coverage or infrastructure

  
upstream
Needs action on someone else's project

  
ux
Interface behaviour and clarity

No labels
architecture
bug
cleanup
docs
packaging
security
testing
upstream
ux
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mysticalsoap/aqomui!199
No description provided.