Move tests to pytest and add a CI job #25

New issue

Closed

opened 2026-08-17 16:57:01 -04:00 by mysticalsoap · 0 comments

mysticalsoap commented

2026-08-17 16:57:01 -04:00

Owner

The five scripts in tests/ already follow the shape pytest formalises
-- test_ovpn_quote.py even skips when OpenVPN is absent. Converting
print/manual-assert to assert + pytest.mark.skipif is mechanical and buys
collection, selection, fixtures and a real exit code.

Keep tests/manual/bypass_cgroup.py out of the default run; it needs root.

Add a CI job running pytest on push. None of the current tests need root,
network or a VPN account, so it runs anywhere. Include a lint step
(ruff/pyflakes, or -W error::SyntaxWarning) -- that alone would have caught
both the escape-sequence warnings and the conf.ROOTDIR typo before they
shipped.

The five scripts in `tests/` already follow the shape pytest formalises -- `test_ovpn_quote.py` even skips when OpenVPN is absent. Converting `print`/manual-assert to `assert` + `pytest.mark.skipif` is mechanical and buys collection, selection, fixtures and a real exit code. Keep `tests/manual/bypass_cgroup.py` out of the default run; it needs root. Add a CI job running `pytest` on push. None of the current tests need root, network or a VPN account, so it runs anywhere. Include a lint step (`ruff`/`pyflakes`, or `-W error::SyntaxWarning`) -- that alone would have caught both the escape-sequence warnings and the `conf.ROOTDIR` typo before they shipped.

mysticalsoap added the

testing

label

2026-08-17 16:57:01 -04:00

mysticalsoap referenced this issue

2026-08-17 21:21:41 -04:00

change: convert the test scripts to pytest #38

mysticalsoap referenced this issue from a pull request that will close it,

2026-08-17 21:40:29 -04:00

Add a CI job running pytest and a minimal lint gate #39

mysticalsoap closed this issue

2026-08-18 12:36:19 -04:00