mysticalsoap/aqomui

Watch

Fork 0

fix: make the application icon work everywhere #55

Merged

mysticalsoap merged 3 commits from mysticalsoap/fix/app-icons into trunk

2026-08-19 11:47:22 -04:00

AGit

mysticalsoap commented

2026-08-19 11:28:25 -04:00

Owner

Problem

The code half of #11 and all of #51. Three stacked misses:

qt5-svg is only an optdepend of python-pyqt5, and without Qt's SVG icon engine fromTheme("aqomui") cannot load our scalable-only hicolor icon — null window icon, null tray icon (the journal's QSystemTrayIcon::setVisible: No Icon set).
On Wayland the taskbar/alt-tab icon comes from matching the window's app_id to a desktop file; ours was the python binary's, matching nothing → the generic fallback-W. On X11 the WM_CLASS (aqomui-gui) never matched aqomui.desktop either.
#51's "application closes when trying to minimize": a QSystemTrayIcon holding a null icon is invisible on most desktops, but isSystemTrayAvailable() still answers yes — so the quit dialog offered Minimize and hid the window into an invisible tray. The process kept running with no way back; it looked closed.

Fix

One commit each:

PKGBUILD: qt5-svg becomes a hard dependency (with a comment on why); main() calls setDesktopFileName("aqomui") for the Wayland app_id match; the desktop file gains StartupWMClass = aqomui-gui for X11.
GUI: systemtray() now treats an unloadable tray icon as "no tray" — window shown normally, and the quit dialog's Minimize option is gated on the tray actually being usable, so the window can never be hidden into nothing.
README: the description now expands the name — Another Qt OpenVPN Management UI — a leftover from the rename sweeps.

Verification

compileall clean; CI runs pytest/ruff
The qt5-svg diagnosis is evidence-based (the dev host lacks it, libQt5Svg.so.5 import fails, and only scalable SVGs are installed for the icon) but the end-to-end result — colored tray icon, correct alt-tab icon, Minimize behaving — needs the rebuilt package installed in a live session to confirm; worth doing as part of the 0.9.0 pass
The no-tray fallback path is the same one already taken when isSystemTrayAvailable() is false, just with a wider trigger

Closes #11
Closes #51

Assisted-by: claude-fable-5

## Problem The code half of [#11](https://git.mysticalsoap.com/mysticalsoap/aqomui/issues/11) and all of [#51](https://git.mysticalsoap.com/mysticalsoap/aqomui/issues/51). Three stacked misses: 1. `qt5-svg` is only an *optdepend* of `python-pyqt5`, and without Qt's SVG icon engine `fromTheme("aqomui")` cannot load our scalable-only hicolor icon — null window icon, null tray icon (the journal's `QSystemTrayIcon::setVisible: No Icon set`). 2. On Wayland the taskbar/alt-tab icon comes from matching the window's app_id to a desktop file; ours was the python binary's, matching nothing → the generic fallback-W. On X11 the WM_CLASS (`aqomui-gui`) never matched `aqomui.desktop` either. 3. #51's "application closes when trying to minimize": a `QSystemTrayIcon` holding a null icon is invisible on most desktops, but `isSystemTrayAvailable()` still answers yes — so the quit dialog offered Minimize and hid the window into an invisible tray. The process kept running with no way back; it *looked* closed. ## Fix One commit each: - **PKGBUILD**: `qt5-svg` becomes a hard dependency (with a comment on why); `main()` calls `setDesktopFileName("aqomui")` for the Wayland app_id match; the desktop file gains `StartupWMClass = aqomui-gui` for X11. - **GUI**: `systemtray()` now treats an unloadable tray icon as "no tray" — window shown normally, and the quit dialog's Minimize option is gated on the tray actually being usable, so the window can never be hidden into nothing. - **README**: the description now expands the name — *Another* Qt OpenVPN Management UI — a leftover from the rename sweeps. ## Verification - `compileall` clean; CI runs pytest/ruff - The qt5-svg diagnosis is evidence-based (the dev host lacks it, `libQt5Svg.so.5` import fails, and only scalable SVGs are installed for the icon) but the end-to-end result — colored tray icon, correct alt-tab icon, Minimize behaving — needs the rebuilt package installed in a live session to confirm; worth doing as part of the 0.9.0 pass - The no-tray fallback path is the same one already taken when `isSystemTrayAvailable()` is false, just with a wider trigger Closes #11 Closes #51 Assisted-by: claude-fable-5

mysticalsoap added 3 commits

2026-08-19 11:28:25 -04:00

fix: let the application icon reach the tray, taskbar and alt-tab 9f2c788ac5

Three misses stacked up to a blank tray and the generic fallback icon:
qt5-svg is only an optdepend of python-pyqt5 but fromTheme() cannot
load our scalable-only hicolor icon without it; the Wayland app_id was
the python binary, matching no desktop file; and on X11 the WM_CLASS
never matched either.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: treat a tray without an icon as no tray 91f202cf95

A QSystemTrayIcon with a null icon is invisible on most desktops, but
isSystemTrayAvailable() still says yes -- so the quit dialog offered
Minimize and hid the window with nothing to bring it back. That is
issue #51's "application closes when trying to minimize".

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

change: expand the a in the README description

ci / test (pull_request) Successful in 48s

Details

ci / test (push) Has been cancelled

Details

dd0b499783

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

mysticalsoap referenced this pull request

2026-08-19 11:44:00 -04:00

change: the tray icon states, not the destination country #57

mysticalsoap merged commit dd0b499783 into trunk

2026-08-19 11:47:22 -04:00

No reviewers

No labels

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

mysticalsoap/aqomui!55

No description provided.

Rows
Columns