mysticalsoap/aqomui
Watch
1
0
Fork
You've already forked aqomui
 0
Code Issues 36 Pull requests 1 Releases 2 Packages Wiki Activity Actions

add: characterization tests for the four kept provider imports #135

Merged
mysticalsoap merged 1 commit from add/provider-parsing-tests into trunk 2026-08-24 01:18:54 -04:00
Conversation 0 Commits 1 Files changed 3 +640
mysticalsoap commented 2026-08-24 00:13:21 -04:00
Owner
Copy link

Problem

#23 gates the provider base-class refactor on the parsing having test coverage — the six routines encode undocumented API knowledge (AirVPN's RSA+AES handshake, Windscribe's CSRF login, Mullvad's scraped table) that a blind refactor would lose. None of it was tested.

Fix

Characterization tests for the four providers #134 keeps: Airvpn, Mullvad, Windscribe, ProtonVPN. A FakeRequests/FakeSession pair stands in for the requests surface update actually uses; dig and iptables are stubbed. Fixtures are trimmed live captures (2026-08-24) of the two still-public endpoints (Mullvad WG relay list, Windscribe server list); everything the live services no longer serve or keep behind credentials is synthetic, shaped by what the parsers read. The Airvpn fake encrypts its replies with the AES key the thread generates, so the real decrypt path runs.

Deliberately pinned quirks, so the refactor preserves or knowingly changes them: Windscribe's ip←ip2/ip2←ip3 field offset and trailing-space city names, Mullvad's legacy OpenVPN protocol table, and today's two live failures (Mullvad's table-less servers page, Windscribe's 404ing cert bundle) each ending as a reported failed import rather than a crash (#32).

Verification

pytest — 324 passed, including the 36 in tests/test_update.py (14 new). ruff check --select E9,F63,F7,F82 . and the SyntaxWarning compileall gate both clean. No test needs network, root or a VPN account; the file's header promise still holds.

## Problem #23 gates the provider base-class refactor on the parsing having test coverage — the six routines encode undocumented API knowledge (AirVPN's RSA+AES handshake, Windscribe's CSRF login, Mullvad's scraped table) that a blind refactor would lose. None of it was tested. ## Fix Characterization tests for the four providers #134 keeps: Airvpn, Mullvad, Windscribe, ProtonVPN. A `FakeRequests`/`FakeSession` pair stands in for the requests surface `update` actually uses; dig and iptables are stubbed. Fixtures are trimmed live captures (2026-08-24) of the two still-public endpoints (Mullvad WG relay list, Windscribe server list); everything the live services no longer serve or keep behind credentials is synthetic, shaped by what the parsers read. The Airvpn fake encrypts its replies with the AES key the thread generates, so the real decrypt path runs. Deliberately pinned quirks, so the refactor preserves or knowingly changes them: Windscribe's ip←ip2/ip2←ip3 field offset and trailing-space city names, Mullvad's legacy OpenVPN protocol table, and today's two live failures (Mullvad's table-less servers page, Windscribe's 404ing cert bundle) each ending as a reported failed import rather than a crash (#32). ## Verification `pytest` — 324 passed, including the 36 in `tests/test_update.py` (14 new). `ruff check --select E9,F63,F7,F82 .` and the SyntaxWarning compileall gate both clean. No test needs network, root or a VPN account; the file's header promise still holds.
add: characterization tests for the four kept provider imports
All checks were successful
ci / test (pull_request) Successful in 28s
Details
ci / test (push) Successful in 49s
Details
bba915d3fe
 
The provider routines encode undocumented API knowledge, and #23 refuses
to refactor them until that knowledge is pinned. These tests pin the
Airvpn, Mullvad, Windscribe and ProtonVPN routines (#134 drops the other
two) through a fake of the requests surface update actually uses --
Session plus module-level get/post sharing one exceptions object.

The JSON fixtures are trimmed live captures (2026-08-24) of the two
still-public endpoints: Mullvad's WireGuard relay list and Windscribe's
server list. Shapes the live services no longer serve (Mullvad's scraped
server table, WINDFLIX entries) or that sit behind paid credentials
(Airvpn's encrypted XML, Proton's logicals) are synthetic, matching what
the parser reads. The Airvpn fake encrypts replies with the AES key the
thread itself generates, so the decrypt path runs without the server's
RSA key.

Two tests pin today's live failures on purpose: Mullvad's table-less
servers page and Windscribe's 404ing cert bundle each end as a reported
failed import (#32).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mysticalsoap deleted branch add/provider-parsing-tests 2026-08-24 01:18:54 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
architecture
Structural change, not a local fix

  
bug
Defect in existing behaviour

  
cleanup
Tidying with no behaviour change

  
docs
Documentation and repo standards

  
packaging
distro packages and their build tooling

  
security
Vulnerability or hardening

  
testing
Test coverage or infrastructure

  
upstream
Needs action on someone else's project

  
ux
Interface behaviour and clarity

No labels
architecture
bug
cleanup
docs
packaging
security
testing
upstream
ux
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mysticalsoap/aqomui!135
No description provided.