change: drop PIA and AzireVPN from the supported providers #136

Merged

mysticalsoap merged 1 commit from change/drop-pia-azirevpn into trunk

2026-08-24 10:44:06 -04:00

mysticalsoap commented

2026-08-24 10:39:20 -04:00

Owner

Problem

#134: PIA and AzireVPN carry no userbase that plausibly overlaps this app's, and their integrations don't hold up — AzireVPN's config generation has never executed in this fork (#20) and PIA's import was never tested (#32). Keeping them means #23's base-class refactor covers six providers where four have tests.

Fix

Deletes the pia() and azirevpn() routines from update.py, the entries in both SUPPORTED_PROVIDERS lists (config.py and the cli's own copy), the provider-form placeholder entries in the gui, the AzireVPN branch in tunnel.py (which carried #20's conf.ROOTDIR AttributeError), the three shipped config templates plus their setup.py listing, and the README mentions. Custom config import remains the path for anyone still on either provider.

Verification

pytest — 324 passed, including #135's provider characterization tests, which cover exactly the four survivors. ruff and compileall gates clean. Post-deletion sweep: no pia/azire reference left anywhere in aqomui/, tests/, packaging/, scripts/, systemd/, setup.py or README (CHANGELOG history intentionally untouched).

Not touched: ruff --select F401 shows six unused imports in update.py (gzip, tarfile, logging, and three inside airvpn()) — all already unused on trunk before this change, so they're a separate cleanup, not riders here.

## Problem #134: PIA and AzireVPN carry no userbase that plausibly overlaps this app's, and their integrations don't hold up — AzireVPN's config generation has never executed in this fork (#20) and PIA's import was never tested (#32). Keeping them means #23's base-class refactor covers six providers where four have tests. ## Fix Deletes the `pia()` and `azirevpn()` routines from update.py, the entries in both `SUPPORTED_PROVIDERS` lists (config.py and the cli's own copy), the provider-form placeholder entries in the gui, the AzireVPN branch in tunnel.py (which carried #20's `conf.ROOTDIR` AttributeError), the three shipped config templates plus their setup.py listing, and the README mentions. Custom config import remains the path for anyone still on either provider. ## Verification `pytest` — 324 passed, including #135's provider characterization tests, which cover exactly the four survivors. `ruff` and compileall gates clean. Post-deletion sweep: no `pia`/`azire` reference left anywhere in `aqomui/`, `tests/`, `packaging/`, `scripts/`, `systemd/`, setup.py or README (CHANGELOG history intentionally untouched). Not touched: `ruff --select F401` shows six unused imports in update.py (`gzip`, `tarfile`, `logging`, and three inside `airvpn()`) — all already unused on trunk before this change, so they're a separate cleanup, not riders here.

mysticalsoap added 1 commit

2026-08-24 10:39:20 -04:00

change: drop PIA and AzireVPN from the supported providers (#134 )

ci / test (pull_request) Successful in 48s

Details

ci / test (push) Successful in 27s

Details

6de801ec2e

Kept providers need a userbase that plausibly overlaps this app's and
integration knowledge that still matches the live API; #134 records why
these two have neither. AzireVPN's config generation never ran once in
this fork (#20) and PIA's import was never tested (#32). Both still work
through custom config import.

Removes the two update routines, the SUPPORTED_PROVIDERS entries (gui
and cli keep separate lists), the provider-form placeholder entries, the
AzireVPN branch in tunnel.py carrying the conf.ROOTDIR AttributeError
from #20, the shipped config templates, and the README mentions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>