Check response status for the five untested providers #32

New issue

Open

opened 2026-08-17 16:57:02 -04:00 by mysticalsoap · 1 comment

mysticalsoap commented

2026-08-17 16:57:02 -04:00

Owner

raise_for_status was added to ProtonVPN only. The other five still read
whatever comes back as if it were the expected payload, so an API that starts
rejecting requests produces a KeyError rather than a reported failure -- and
an error document can be written out as a certificate.

Deferred because some flows may legitimately expect a non-2xx mid-sequence
(Windscribe's login, update.py:552-609) and there is no account here to test
against. Do it alongside the provider-structure work, with captured fixtures.

`raise_for_status` was added to ProtonVPN only. The other five still read whatever comes back as if it were the expected payload, so an API that starts rejecting requests produces a `KeyError` rather than a reported failure -- and an error document can be written out as a certificate. Deferred because some flows may legitimately expect a non-2xx mid-sequence (Windscribe's login, `update.py:552-609`) and there is no account here to test against. Do it alongside the provider-structure work, with captured fixtures.

mysticalsoap added the

bug

label

2026-08-17 16:57:02 -04:00

mysticalsoap referenced this issue

2026-08-24 00:03:33 -04:00

Drop PIA and AzireVPN from the supported providers #134

mysticalsoap commented

2026-08-24 00:03:50 -04:00

Author

Owner

Probed the live endpoints 2026-08-24. Scope note first: PIA and AzireVPN are dropped per #134, so this issue covers Mullvad, Windscribe and Airvpn (Proton's 401 is #33's).

Mullvad — import is dead end-to-end. /en/servers/ no longer contains the scraped table (table-container: 0 matches — the page is a JS app now), so server_parse[0] raises before the WireGuard section runs, and the whole import lands as a failed import. OpenVPN is gone server-side anyway (removed 2026-01-15), so the fix is dropping the scrape, not repairing it. The WG endpoints still answer: public/relays/wireguard/v1/ is 200 unauthenticated, and the legacy /wg/ key upload answers 400-not-404 to garbage input — still parsing requests, but Mullvad's own apps moved to the devices API, so the upload needs a real-account test before trusting it.
Windscribe — cert bundle 404s. assets.windscribe.com/desktop/other/openvpn_cert.zip is gone, so windscribe_get_servers dies in zipfile (BadZipFile → failed import) right after a successful login. The server list itself is fine: serverlist/openvpn/1/<uuid> returns 200 unauthenticated, ~229KB JSON, current shape matches what the parser expects.
Airvpn — not probed; the whole exchange sits behind account credentials. No evidence either way yet.

Probed the live endpoints 2026-08-24. Scope note first: PIA and AzireVPN are dropped per #134, so this issue covers Mullvad, Windscribe and Airvpn (Proton's 401 is #33's). - **Mullvad — import is dead end-to-end.** `/en/servers/` no longer contains the scraped table (`table-container`: 0 matches — the page is a JS app now), so `server_parse[0]` raises before the WireGuard section runs, and the whole import lands as a failed import. OpenVPN is gone server-side anyway (removed 2026-01-15), so the fix is dropping the scrape, not repairing it. The WG endpoints still answer: `public/relays/wireguard/v1/` is 200 unauthenticated, and the legacy `/wg/` key upload answers 400-not-404 to garbage input — still parsing requests, but Mullvad's own apps moved to the devices API, so the upload needs a real-account test before trusting it. - **Windscribe — cert bundle 404s.** `assets.windscribe.com/desktop/other/openvpn_cert.zip` is gone, so `windscribe_get_servers` dies in `zipfile` (BadZipFile → failed import) right after a successful login. The server list itself is fine: `serverlist/openvpn/1/<uuid>` returns 200 unauthenticated, ~229KB JSON, current shape matches what the parser expects. - **Airvpn — not probed**; the whole exchange sits behind account credentials. No evidence either way yet.

mysticalsoap referenced this issue from a commit

2026-08-24 00:13:05 -04:00

add: characterization tests for the four kept provider imports

mysticalsoap referenced this issue

2026-08-24 00:13:22 -04:00

add: characterization tests for the four kept provider imports #135

mysticalsoap referenced this issue from a commit

2026-08-24 10:38:53 -04:00

change: drop PIA and AzireVPN from the supported providers (#134)

mysticalsoap referenced this issue

2026-08-24 10:39:20 -04:00

change: drop PIA and AzireVPN from the supported providers #136