mysticalsoap/aqomui
Watch
1
0
Fork
You've already forked aqomui
 0
Code Issues 36 Pull requests 1 Releases 2 Packages Wiki Activity Actions

change: drop the pre-fork legacy config layout #137

Merged
mysticalsoap merged 1 commit from change/drop-legacy-config-layout into trunk 2026-08-24 10:52:31 -04:00
Conversation 0 Commits 1 Files changed 7 +1 -107
mysticalsoap commented 2026-08-24 10:50:49 -04:00
Owner
Copy link

Problem

#54: resources/ ships two config templates per provider. The *_config_old set exists only for tunnel.py's fallback, which serves installs whose providers were imported by pre-fork qomui and rewrites cert paths back to the shared certs/ layout. This fork has no such upgrade path to honor — importing again is the only way to get a working provider here.

Closes #54.

Fix

Deletes the four *_config_old templates and their setup.py entries, the tunnel.py fallback plus its path-rewrite loop, and delete_provider's cleanup of the legacy certs/<provider>-auth.txt. A provider directory missing openvpn.conf now surfaces as a reported connection failure via GuardedThread instead of silently connecting with a stale template.

Verification

pytest — 324 passed; ruff and compileall gates clean. Post-deletion sweep: no config_old, compat or legacy-certs/ reference left in aqomui/ or setup.py.

## Problem #54: resources/ ships two config templates per provider. The `*_config_old` set exists only for tunnel.py's fallback, which serves installs whose providers were imported by pre-fork qomui and rewrites cert paths back to the shared `certs/` layout. This fork has no such upgrade path to honor — importing again is the only way to get a working provider here. Closes #54. ## Fix Deletes the four `*_config_old` templates and their setup.py entries, the tunnel.py fallback plus its path-rewrite loop, and `delete_provider`'s cleanup of the legacy `certs/<provider>-auth.txt`. A provider directory missing `openvpn.conf` now surfaces as a reported connection failure via GuardedThread instead of silently connecting with a stale template. ## Verification `pytest` — 324 passed; `ruff` and compileall gates clean. Post-deletion sweep: no `config_old`, `compat` or legacy-`certs/` reference left in `aqomui/` or setup.py.
change: drop the pre-fork legacy config layout (#54)
All checks were successful
ci / test (pull_request) Successful in 28s
Details
ci / test (push) Successful in 28s
Details
2226e95391
 
The *_config_old templates and tunnel.py's fallback to them served
installs whose providers were imported by qomui before the per-provider
directory layout, rewriting cert paths back to the shared certs/ dir.
This fork has no such upgrade path to honor: importing again is the only
way to get a working provider here. delete_provider's cleanup of the
legacy certs/<provider>-auth.txt goes with it.

A provider directory missing openvpn.conf now surfaces as a reported
connection failure via GuardedThread instead of silently connecting
with a stale template.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mysticalsoap deleted branch change/drop-legacy-config-layout 2026-08-24 10:52:32 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
architecture
Structural change, not a local fix

  
bug
Defect in existing behaviour

  
cleanup
Tidying with no behaviour change

  
docs
Documentation and repo standards

  
packaging
distro packages and their build tooling

  
security
Vulnerability or hardening

  
testing
Test coverage or infrastructure

  
upstream
Needs action on someone else's project

  
ux
Interface behaviour and clarity

No labels
architecture
bug
cleanup
docs
packaging
security
testing
upstream
ux
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mysticalsoap/aqomui!137
No description provided.